lvyanquan commented on PR #4214: URL: https://github.com/apache/flink-cdc/pull/4214#issuecomment-5790857825
Thanks @yuxiqian and @leonardBang. I updated the PR in commit `13681652c`. Changes: - Rebased the branch onto the latest `master` and resolved the conflicts. - Added a dedicated `testPreEpochTimestamp` ITCase pinned to `Asia/Shanghai`. It verifies the `1900-01-01` value in both the snapshot and WAL update stages. - Restored the original ordered assertion in `testAllTypes`; the new regression test verifies the target row’s exact `+I -> -D -> +I` sequence. - Added `CustomPostgresValueConverterTest` covering null and non-timestamp input, positive and negative infinity, 1600, 1900, the pre-epoch and epoch boundaries, and post-epoch timestamps. - Added class and method documentation explaining the historical LMT issue, the reason for using `Timestamp.toLocalDateTime()`, the intentionally unused parameters, and the scope of the change. - Moved the pre-epoch test data setup into the dedicated ITCase, so `column_type_test.sql` is no longer changed and the trailing-newline/duplicated-fixture observations no longer apply to this diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
