lvyanquan commented on PR #4214: URL: https://github.com/apache/flink-cdc/pull/4214#issuecomment-5810939141
Pushed `7c52a4f39` for the upgrade-compatibility concern: - New option `scan.pre-epoch-timestamp.wall-clock-conversion.enabled`, default `false` -> previous behavior is kept (`super.convertTimestampToLocalDateTime`); `true` -> the wall clock stored in PostgreSQL is kept. - Supported by the SQL source, the DataStream source (same key in `debeziumProperties`) and the Postgres pipeline connector; en/zh docs updated for both connectors. - Tests: converter unit tests for both modes (including equality with a stock `PostgresValueConverter`), an opt-in ITCase covering the snapshot and WAL phases, an ITCase asserting the unchanged default behavior, and a pipeline factory wiring test. Green on Flink 1.20 and Flink 2.2 (JDK 17). - Documented limitation: no effect when `scan.incremental.snapshot.enabled=false`. Supporting data point: under the previous conversion the same pre-epoch row is read as `1900-01-01T00:05:43.123` during the snapshot phase but as `1900-01-01T00:00:00.123` from the WAL (`Asia/Shanghai`), so the two phases of one job disagree. With the option enabled both phases return the stored value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
