MartijnVisser commented on code in PR #29276:
URL: https://github.com/apache/flink/pull/29276#discussion_r4093553976
##########
pom.xml:
##########
@@ -1083,12 +1083,24 @@ under the License.
</activation>
</profile>
+ <profile>
+ <id>spotless-java11</id>
+ <activation>
+ <jdk>[11,17)</jdk>
+ </activation>
+
+ <properties>
+ <!-- google-java-format 1.25.0 and later need
Java 17 to run. Select by JDK, not by
+ java11-target: the release profile
also builds for Java 11 without it. -->
+ <aosp.version>1.24.0</aosp.version>
+ </properties>
Review Comment:
`java11` activates on `[11,)`, so JDK 17 and 21 would drop to 1.24.0
(checked with `help:evaluate`). Adding 1.28.0 to `java17` fixes that, but
relies on profile order. I'd keep `[11,17)`, where no other profile sets it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
