leonardBang commented on code in PR #4565: URL: https://github.com/apache/flink-cdc/pull/4565#discussion_r4246354051
########## NOTICE: ########## @@ -4,6 +4,149 @@ Copyright 2024-2026 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +This project bundles the following dependencies under the MIT license. +See bundled license files for details. + +- AnchorJS v3.1.0 (https://github.com/bryanbraun/anchorjs) Copyright (c) 2016 Bryan Braun + -> in "docs/static/js/anchor.min.js" +- font-awesome:4.6.3 (css) (https://fontawesome.com/) - Created by Dave Gandy + -> css in "docs/static/font-awesome/css" +- chroma (css generated by Hugo) (https://github.com/alecthomas/chroma) Copyright (C) 2017 Alec Thomas + -> in "docs/assets/github.css" +- Hugo Book theme (https://github.com/alex-shpak/hugo-book) Copyright (c) 2018 Alex Shpak + -> in "docs/themes/book" + +The Flink CDC binary distributions bundle the following dependencies under the MIT license. Review Comment: 这里是否需要同步更新各独立发布 JAR 的 `META-INF/NOTICE`？当前根目录 `NOTICE` 只会由 `flink-cdc-dist` assembly 复制到 binary tar；Pipeline Connector、fat SQL Connector 和 model JAR 都携带各自独立的 `META-INF/NOTICE`。例如构建出的 Fluss connector JAR 中目前仍只有 ASF boilerplate，因此这里新增的 Orekit/Jackson attribution 不会随独立 JAR 发布。是否可以补齐各 artifact 的 NOTICE，或在构建时聚合生成并增加最终 JAR 的解包校验？ ########## NOTICE: ########## @@ -4,6 +4,149 @@ Copyright 2024-2026 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +This project bundles the following dependencies under the MIT license. +See bundled license files for details. Review Comment: 这里提到 “See bundled license files for details”，但当前 source tree 中除 `docs/themes/book/LICENSE` 外，没有看到 AnchorJS、Font Awesome 和 Chroma 对应的 license files，根目录 `LICENSE` 也只有 Apache License 2.0。是否需要补齐这些第三方 license 文件（或聚合到专门的 LICENSE 文件），并增加 source archive 的打包校验？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
