leonardBang commented on code in PR #4565: URL: https://github.com/apache/flink-cdc/pull/4565#discussion_r4254349575
########## NOTICE: ########## @@ -4,6 +4,149 @@ Copyright 2024-2026 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +This project bundles the following dependencies under the MIT license. +See bundled license files for details. Review Comment: Thanks for addressing the JAR-specific NOTICE files. I rechecked the source packaging path, and would it make sense to cover the source distribution separately as well? `create_source_release.sh` performs a clean clone and copies it without initializing submodules, so the Hugo Book content and its license are not included in the resulting source archive. For the third-party assets that are included directly—AnchorJS, Font Awesome, and the Chroma-generated CSS—the root `LICENSE` still contains only the Apache License 2.0 text, and I could not find the corresponding bundled license texts. Could we either add dedicated/aggregated third-party license files and verify their presence in the generated source archive, or remove entries for content that is not actually shipped? This would keep the `See bundled license files for details` statement consistent with the final source tarball. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
