SEPURI-SAI-KRISHNA commented on code in PR #29345:
URL: https://github.com/apache/flink/pull/29345#discussion_r4284113056
##########
flink-table/flink-table-test-utils/src/main/java/org/apache/flink/table/runtime/functions/ListViewStateConverter.java:
##########
@@ -76,4 +80,15 @@ public Object toExternal(Object internal) {
public Object createNewInternalState() {
return new GenericArrayData(new Object[0]);
}
+
+ @Override
+ public Object copyInternal(Object internal) {
+ final ArrayData arrayData = (ArrayData) internal;
Review Comment:
Done, same field name as your snippet. I did not do the same for
`MapViewStateConverter`: `MapDataSerializer.copy` returns `BinaryMapData` while
`toInternal` and `createNewInternalState` produce `GenericMapData`.
`ArrayDataSerializer.copy` keeps `GenericArrayData`, so the list case has no
such mismatch. Happy to switch both if you prefer the consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
