SEPURI-SAI-KRISHNA commented on code in PR #29345:
URL: https://github.com/apache/flink/pull/29345#discussion_r4284154218
##########
flink-table/flink-table-test-utils/src/main/java/org/apache/flink/table/runtime/functions/ProcessTableFunctionTestHarness.java:
##########
@@ -155,7 +155,11 @@ private static class TableArgumentConverters {
@Nullable private InvocationContext currentInvocation;
+ /** The configuration this harness was built with, kept for {@link
#snapshot()}. */
+ private final Builder<OUT> builder;
Review Comment:
Done, a private immutable `HarnessSpec` built at `build()` time, held by the
harness and by `TestSnapshot`. It is structurally immutable rather than deeply:
`PartitionConfiguration` holds a `String[]` and the initial state holds user
objects, so a caller who kept a reference can still mutate those. Happy to
clone the arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
