Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3151#discussion_r99566630
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ---
    @@ -741,6 +763,18 @@ private void establishJobManagerConnection(JobID 
jobId, JobMasterGateway jobMast
                        jobManagerTable.put(jobId, 
associateWithJobManager(jobMasterGateway, jobManagerLeaderId, 
registrationSuccess.getBlobPort()));
                }
     
    +           
heartbeatManager.monitorTarget(registrationSuccess.getResourceID(), new 
HeartbeatTarget() {
    +                   @Override
    +                   public void sendHeartbeat(ResourceID resourceID, Object 
payload) {
    +                           
jobMasterGateway.heartbeatFromTaskManager(resourceID, payload);
    +                   }
    +
    +                   @Override
    +                   public void requestHeartbeat(ResourceID resourceID, 
Object payload) {
    +                           throw new UnsupportedOperationException("Should 
never call requestHeartbeat in task manager.");
    --- End diff --
    
    A heartbeat request is totally fine. This should not throw an 
`UnsupportedOperationException` but trigger a heartbeat being sent back to 
`resourceID`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to