Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3151#discussion_r99825777
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java
 ---
    @@ -218,4 +218,12 @@ void failSlot(final ResourceID taskManagerId,
                        final TaskManagerLocation taskManagerLocation,
                        final UUID leaderId,
                        @RpcTimeout final Time timeout);
    +
    +   /**
    +    * Send the heartbeat to job manager from task manager
    +    *
    +    * @param resourceID unique id of the task manager
    +    * @param payload the payload information from the task manager
    +    */
    +   void heartbeatFromTaskManager(final ResourceID resourceID, final Object 
payload);
    --- End diff --
    
    If it's `Void` at the moment, why not leaving this parameter out for the 
moment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to