wenjin272 commented on code in PR #1295: URL: https://github.com/apache/flink-agents/pull/1295#discussion_r4324173686
########## tools/releasing/create_binary_release.sh: ########## @@ -43,6 +43,13 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then exit 1 fi +# Check JDK version - must be JDK 21 +JAVA_VERSION=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | cut -d'.' -f1) Review Comment: Could we enforce JDK 21 through the existing Maven Enforcer rule in the `release` profile, using `<version>[21,22)</version>`, and remove the duplicate checks from both release scripts? The scripts currently check `java` on `PATH`, while Maven uses `JAVA_HOME` when set, so the check can pass even when Maven actually runs on JDK 17. Both scripts already enable `-Prelease`, so this would validate the JVM performing the build while keeping the existing bytecode targets unchanged. While updating the staging script, could we also remove the obsolete second deployment with `-Pjava-11-target` and update the related log messages? That profile was removed in #452, so it no longer produces a `jdk11` classifier. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
