sangkyoonnam commented on code in PR #1295: URL: https://github.com/apache/flink-agents/pull/1295#discussion_r4325455753
########## tools/releasing/create_binary_release.sh: ########## @@ -43,6 +43,13 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then exit 1 fi +# Check JDK version - must be JDK 21 +JAVA_VERSION=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | cut -d'.' -f1) Review Comment: Done in a01dfaa9. The `release` profile's `requireJavaVersion` is now `[21,22)`, and both scripts drop their own checks. Local runs reject Maven on JDK 17 and pass on JDK 21, even with the opposite `java` on `PATH`; staging was checked with `install` in place of `deploy`. I also removed the obsolete `-Pjava-11-target` deployment and updated the staging log messages, which now print `mvn -version`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
