MartijnVisser opened a new pull request, #254:
URL: https://github.com/apache/flink-connector-jdbc/pull/254
## What is the purpose of the change
* `JdbcDynamicTableSink` moves from the deprecated `SinkFunctionProvider`
(FLINK-36245) to `SinkV2Provider` over an internal, writer-only
`Sink<RowData>`. This drops FLIP-239's separate `JdbcDynamicTableSinkV2`, so it
stays a draft until the dev@ thread on that has run.
## Brief change log
* The remaining test sinks move onto Sink V2
* `JdbcWriter` takes the `@Public` `WriterInitContext` instead of the
`@Internal` `InitContext`
* `JdbcWriter` gets a constructor over a prebuilt `JdbcOutputFormat`, and
`JdbcSinkBuilder` rejects `maxRetries > 0` for exactly-once on the client
* `JdbcTableSink` replaces `GenericJdbcSinkFunction`
## Verifying this change
This change added tests and can be verified as follows:
* `JdbcDynamicTableSinkITCase` runs the SQL sink of every dialect on Sink V2
and checks the provider, `sink.parallelism` and the flush on checkpoint
* `JdbcSinkBuilderTest` and `testPrebuiltOutputFormat` cover the builder
check and the new `JdbcWriter` constructor
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Fable 5.1, Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
