MartijnVisser commented on code in PR #254:
URL:
https://github.com/apache/flink-connector-jdbc/pull/254#discussion_r4334824563
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/sink/JdbcDynamicTableSink.java:
##########
@@ -81,8 +80,7 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
builder.setJdbcExecutionOptions(executionOptions);
builder.setFieldDataTypes(
DataType.getFieldDataTypes(physicalRowDataType).toArray(new
DataType[0]));
- return SinkFunctionProvider.of(
- new GenericJdbcSinkFunction<>(builder.build()),
jdbcOptions.getParallelism());
+ return SinkV2Provider.of(new JdbcTableSink(builder.build()),
jdbcOptions.getParallelism());
Review Comment:
I've added `JdbcTableSinkMigrationITCase`, same shape as
`FileSinkMigrationITCase`: a job on the 4.x sink function stops with a
savepoint and the Sink V2 sink restores it under the same uids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
