RocMarshal commented on code in PR #120:
URL: https://github.com/apache/flink-benchmarks/pull/120#discussion_r4348770296


##########
src/main/java/org/apache/flink/benchmark/functions/SkewableHigherMultiply.java:
##########
@@ -28,6 +28,7 @@ public class SkewableHigherMultiply extends 
RichMapFunction<Long, Long> {
 
     private final int additionalCostMillisPerRecord;

Review Comment:
   Thanks @AlexYinHan 
   
   Could we split this attribute into two for consise semantic :
   
   - additionalCostMillisPerBatch
   - recordsOfAdditionalCostMillis
   
   WDYTA?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to