MartijnVisser opened a new pull request, #336:
URL: https://github.com/apache/flink-connector-kafka/pull/336
## What is the purpose of the change
Recovery reports from the dynamic source were keyed by the formatted split
id, which collides across clusters (`a` + `b-c` and `a-b` + `c` are both
`a-b-c-0`). One partition was dropped, or the restore failed. This builds on
#323 (FLINK-40710) and needs a rebase once that is merged.
## Brief change log
- `ReaderRecoveryGate.mergeReportedSplits` and `reassignReportedSplits`
key by `toPartitionKey`, in the same order as before for unique ids
## Verifying this change
This change added tests and can be verified as follows:
- `ReaderRecoveryGateTest` and `DynamicKafkaSourceEnumeratorRecoveryTest`
cover colliding ids in both paths, bounded and unbounded. 9 cases fail without
the fix.
- `GlobalSplitOwnerAssigner` still keys by split id, which only affects
balance in global mode
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency, including
`kafka.version` or `flink.version`): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)` or `@Experimental`, or are the Table options or the PyFlink
wrappers changed: no
- Checkpointed state, its serializers, or exactly-once delivery (splits,
enumerator state, writer state, committables, transactions): no
- The per-record code paths (split reader, record emitter, writer,
serialization schemas; performance sensitive): no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
- If the docs changed, are both `docs/content` and `docs/content.zh`
updated? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code 2.1.308 (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
