spuru9 opened a new pull request, #177: URL: https://github.com/apache/flink-shaded/pull/177
## What Bump `netty.tcnative.version` on the `release-21.0` line from `2.0.74.Final` to `2.0.84.Final` in `flink-shaded-netty-tcnative-dynamic` and `flink-shaded-netty-tcnative-static`, and update their `NOTICE` files to match. JIRA: https://issues.apache.org/jira/browse/FLINK-41076 (follow-up to #174, which bumped Netty to `4.2.19.Final`) ## Why Both modules' poms say the tcnative version should follow the `tcnative.version` property in Netty's root pom. #174 moved Netty to `4.2.19.Final` but left tcnative at `2.0.74.Final`, while Netty 4.2.19's BOM uses `2.0.84.Final`. The two are not compatible: the OpenSSL engine in Netty 4.2.19 (`ReferenceCountedOpenSslEngine$DefaultOpenSslSession`) calls `SSL.getGroupName(long)`, which is not present in tcnative `2.0.74.Final`. With the shaded Netty from #174 and the 2.0.74 tcnative modules, an OpenSSL-provider handshake would fail with `NoSuchMethodError`; the default JDK SSL provider is not affected. ## Changes - **`flink-shaded-netty-tcnative-dynamic/pom.xml`**, **`flink-shaded-netty-tcnative-static/pom.xml`** — `netty.tcnative.version` `2.0.74.Final` → `2.0.84.Final` (the module version coordinate follows it, `2.0.84.Final-21.0`). - **`flink-shaded-netty-tcnative-dynamic/src/main/resources/META-INF/NOTICE`** — the 6 `io.netty:netty-tcnative*` lines → `2.0.84.Final`. - **`flink-shaded-netty-tcnative-static/src/main/resources/META-INF/NOTICE`** — the 7 `io.netty:netty-tcnative*` lines → `2.0.84.Final`. No NOTICE entries are added or removed; all classifiers used by the dynamic and static modules resolve for `2.0.84.Final`. ## Verification Ran the steps of `.github/workflows/ci.yml` locally in Docker (`maven:3.8.6-eclipse-temurin-11`: Java 11.0.17, Maven 3.8.6): full-reactor `mvn clean deploy -U -B -Pinclude-netty-tcnative-static -Plicense-check`, then `mvn exec:java@check-license -N`: - `BUILD SUCCESS`; `flink-shaded-netty-tcnative-dynamic` and `-static` build as `2.0.84.Final-21.0`. - `LicenseChecker`: "License check completed without severe issues." - The relocated `SSL` class in both built jars contains `getGroupName`. An end-to-end OpenSSL handshake and unit tests were not run. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes (please specify the tool below) Generated-by: Claude Code (claude-sonnet-5-5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
