[ 
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855166#comment-15855166
 ] 

ASF GitHub Bot commented on FLINK-4364:
---------------------------------------

Github user wangzhijiang999 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3151#discussion_r99732047
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ---
    @@ -1058,6 +1092,30 @@ public void handleError(Throwable throwable) {
                }
        }
     
    +   /**
    +    * The heartbeat listener for JobManager and ResourceManager, they can 
be distinguished by ResourceID
    +    * and trigger different processes.
    +    */
    +   private final class JMRMHeartbeatListener implements HeartbeatListener {
    --- End diff --
    
    From TaskExecutor side, it will monitor the JM and RM that initiate the 
heartbeat, so JMRMHeartbeatListener indicates the heartbeat timeout with JM or 
RM, the current PR just shows the interaction with JM part. I am supposed to 
submit the RM part in another PR, maybe submit both sides together will help to 
understand easily.


> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
>                 Key: FLINK-4364
>                 URL: https://issues.apache.org/jira/browse/FLINK-4364
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and 
> the {{TaskManager}} will report metrics info for each heartbeat.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to