[
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855171#comment-15855171
]
ASF GitHub Bot commented on FLINK-4364:
---------------------------------------
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99732610
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -1058,6 +1092,30 @@ public void handleError(Throwable throwable) {
}
}
+ /**
+ * The heartbeat listener for JobManager and ResourceManager, they can
be distinguished by ResourceID
+ * and trigger different processes.
+ */
+ private final class JMRMHeartbeatListener implements HeartbeatListener {
+
+ JMRMHeartbeatListener() {
+ }
+
+ @Override
+ public void notifyHeartbeatTimeout(final ResourceID resourceID)
{
+ log.info("Notify heartbeat timeout for resourceID {}",
resourceID);
--- End diff --
Yes, it actually should trigger some actions with timeout. Currently I did
not submit this part because I think it is related with failure detection logic
and supposed to submit in another PR. To make the heartbeat mechanism
complete, I will add this part in the following modifications.
> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
> Key: FLINK-4364
> URL: https://issues.apache.org/jira/browse/FLINK-4364
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and
> the {{TaskManager}} will report metrics info for each heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
