Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99827091
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -1058,6 +1092,30 @@ public void handleError(Throwable throwable) {
}
}
+ /**
+ * The heartbeat listener for JobManager and ResourceManager, they can
be distinguished by ResourceID
+ * and trigger different processes.
+ */
+ private final class JMRMHeartbeatListener implements HeartbeatListener {
+
+ JMRMHeartbeatListener() {
+ }
+
+ @Override
+ public void notifyHeartbeatTimeout(final ResourceID resourceID)
{
+ log.info("Notify heartbeat timeout for resourceID {}",
resourceID);
--- End diff --
I think it would be enough to create the respective handler method in the
`TaskExecutor`. The actual handling can then be implemented in a separate PR.
But that way, we can easily test the behaviour by checking whether this method
was called in case of a timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
