semlanghi commented on PR #1337:
URL: https://github.com/apache/flink-agents/pull/1337#issuecomment-6607863704
@sharpca the Java side is pushed (372988d6), so you can mirror it. The PR
description has the full rule list and test cases. Two notes for the Python
version check:
- On the Java side, an unknown version behaves like 1.20 (try both files).
With `flink_version_manager`, `ge("2.0.0")` as the "is 2.x" test gives the same
result, since it returns `False` when PyFlink isn't installed. Using
`lt("2.0.0")` as "is 1.x" would invert the unknown case.
- PEP 440 local versions such as `1.20+vvr.11.0.dev0` normalise to `1.0.0`
in `_normalize_version`, because it stops at `20+vvr`. That still lands below
2.0, so it's harmless for this check, but worth knowing if you touch the
parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
