semlanghi commented on PR #1337: URL: https://github.com/apache/flink-agents/pull/1337#issuecomment-6606601006
Thanks @sharpca, happy to split it that way: Java stays in #1337, Python in #1347. I'll push the Java side shortly so you can mirror it. **Version source.** I'll use `EnvironmentInformation.getVersion()` from `flink-runtime`, i.e. the Flink the job actually runs on. Major.minor comes from the part before the first `-`, so `1.20.3` and potential vendor builds like `1.20-<vendor_id>` both read as 1.20. If the version is unknown or unparseable, it falls back to the 1.20 behaviour (try both files) so a missing version never breaks a job. `flink_version_manager` is the natural Python equivalent. **Legacy parser.** Not in the current head yet. It will be part of #1337, not a follow-up, and will mirror `GlobalConfiguration.loadLegacyYAMLResource()` as in Apache Flink 1.20.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
