[
https://issues.apache.org/jira/browse/FLINK-5406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860905#comment-15860905
]
ASF GitHub Bot commented on FLINK-5406:
---------------------------------------
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3101#discussion_r100488613
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/NormalizationRulesTests.scala
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table
+
+import org.apache.calcite.rel.rules.AggregateExpandDistinctAggregatesRule
+import org.apache.calcite.tools.RuleSets
+import org.apache.flink.api.scala._
+import org.apache.flink.table.api.scala._
+import org.apache.flink.table.calcite.{CalciteConfig,
CalciteConfigBuilder, RuleSetConfig,
+RuleSetConfigBuilder}
+import org.apache.flink.table.utils.TableTestBase
+import org.apache.flink.table.utils.TableTestUtil._
+import org.junit.Test
+
+class NormalizationRulesTests extends TableTestBase {
--- End diff --
CalciteConfigBuilderTest just tests the correctness of CalciteConfig, does
not test logical plan changing when applied a rule. However
NormalizationRulesTest tests the correctness of a logical plan when applied a
normalization rule. I suggest we keep NormalizationRulesTest.
> add normalization phase for predicate logical plan rewriting between
> decorrelate query phase and volcano optimization phase
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-5406
> URL: https://issues.apache.org/jira/browse/FLINK-5406
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: godfrey he
> Assignee: godfrey he
>
> Normalization phase is for predicate logical plan rewriting and is
> independent of cost module. The rules in normalization phase do not need to
> repeatedly applied to different logical plan which is different to volcano
> optimization phase. And the benefit of normalization phase is to reduce the
> running time of volcano planner.
> *ReduceExpressionsRule* can apply various simplifying transformations on
> RexNode trees. Currently, there are two transformations:
> 1) Constant reduction, which evaluates constant subtrees, replacing them with
> a corresponding RexLiteral
> 2) Removal of redundant casts, which occurs when the argument into the cast
> is the same as the type of the resulting cast expression
> the above transformations do not depend on the cost module, so we can move
> the rules in *ReduceExpressionsRule* from
> DATASET_OPT_RULES/DATASTREAM_OPT_RULES to DataSet/DataStream Normalization
> Rules.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
