Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102179118
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
---
@@ -122,10 +198,19 @@ public ElasticsearchSinkBase(
"The object probably contains or references non
serializable fields.");
}
- checkNotNull(userConfig);
+ try {
+ InstantiationUtil.serializeObject(failureHandler);
+ } catch (Exception e) {
+ throw new IllegalArgumentException(
+ "The implementation of the provided
ActionRequestFailureHandler is not serializable. " +
+ "The object probably contains or
references non serializable fields.");
+ }
--- End diff --
This looks a bit like duplicate code. I think adding a utility into the
`InstantiationUtil` that is called `isSerializable()` would be cleaner and save
some LOC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
