[ 
https://issues.apache.org/jira/browse/FLINK-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887804#comment-15887804
 ] 

ASF GitHub Bot commented on FLINK-5157:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2946#discussion_r103427991
  
    --- Diff: 
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AllWindowedStream.scala
 ---
    @@ -199,6 +198,62 @@ class AllWindowedStream[T, W <: Window](javaStream: 
JavaAllWStream[T, W]) {
         asScalaStream(javaStream.reduce(reducer, applyFunction, returnType))
       }
     
    +  /**
    +    * Applies the given window function to each window. The window 
function is called for each
    +    * evaluation of the window for each key individually. The output of 
the window function is
    +    * interpreted as a regular non-windowed stream.
    +    *
    +    * Arriving data is pre-aggregated using the given pre-aggregation 
reducer.
    +    *
    +    * @param preAggregator The reduce function that is used for 
pre-aggregation
    +    * @param windowFunction The process window function.
    +    * @return The data stream that is the result of applying the window 
function to the window.
    +    */
    +  def reduce[R: TypeInformation](
    --- End diff --
    
    The new methods should be `@PublicEvolving`. I know the existing methods 
aren't, but they should be and are only like this due to oversights. 😅 
    
    That's not an error on your side.


> Extending AllWindow Function Metadata
> -------------------------------------
>
>                 Key: FLINK-5157
>                 URL: https://issues.apache.org/jira/browse/FLINK-5157
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataStream API, Streaming
>            Reporter: Ventura Del Monte
>            Assignee: Ventura Del Monte
>
> Following the logic behind [1,2], ProcessAllWindowFunction can be introduced 
> in Flink and AllWindowedStream can be extended in order to support them. 
> [1] 
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-2+Extending+Window+Function+Metadata
> [2] https://issues.apache.org/jira/browse/FLINK-4997



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to