[ 
https://issues.apache.org/jira/browse/FLINK-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887803#comment-15887803
 ] 

ASF GitHub Bot commented on FLINK-5157:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2946#discussion_r103425179
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java
 ---
    @@ -478,6 +581,135 @@ public AllWindowedStream(DataStream<T> input,
                return input.transform(opName, resultType, 
operator).forceNonParallel();
        }
     
    +   /**
    +    * Applies the given window function to each window. The window 
function is called for each
    +    * evaluation of the window for each key individually. The output of 
the window function is
    +    * interpreted as a regular non-windowed stream.
    +    *
    +    * <p>Arriving data is incrementally aggregated using the given 
aggregate function. This means
    +    * that the window function typically has only a single value to 
process when called.
    +    *
    +    * @param aggFunction The aggregate function that is used for 
incremental aggregation.
    +    * @param windowFunction The process window function.
    +    *
    +    * @return The data stream that is the result of applying the window 
function to the window.
    +    *
    +    * @param <ACC> The type of the AggregateFunction's accumulator
    +    * @param <V> The type of AggregateFunction's result, and the 
WindowFunction's input
    +    * @param <R> The type of the elements in the resulting stream, equal 
to the
    +    *            WindowFunction's result type
    +    */
    +   public <ACC, V, R> SingleOutputStreamOperator<R> aggregate(
    --- End diff --
    
    These should also be `@PublicEvolving`. (I know that the corresponding 
methods on `WindowedStream` weren't marked like this due to an oversight on the 
implementers side.) No problem. 😃 


> Extending AllWindow Function Metadata
> -------------------------------------
>
>                 Key: FLINK-5157
>                 URL: https://issues.apache.org/jira/browse/FLINK-5157
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataStream API, Streaming
>            Reporter: Ventura Del Monte
>            Assignee: Ventura Del Monte
>
> Following the logic behind [1,2], ProcessAllWindowFunction can be introduced 
> in Flink and AllWindowedStream can be extended in order to support them. 
> [1] 
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-2+Extending+Window+Function+Metadata
> [2] https://issues.apache.org/jira/browse/FLINK-4997



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to