Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3479#discussion_r105661210
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -628,6 +644,123 @@ protected final boolean isCleanupTime(W window, long
time) {
return time == cleanupTime(window);
}
+ public abstract class KeyedStateStoreWithWindow implements
KeyedStateStore {
--- End diff --
Maybe comment that we have a base class where we can set the window so that
we can once create a `MergingKeyStore` or `WindowPaneKeyStore` (depending on
the window assigner) and then not care about the distinction anymore.
I remember I suggested this but now struggled to see why there is the base
class. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
