Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3479#discussion_r105662139
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/windowing/FoldApplyProcessWindowFunction.java
---
@@ -92,12 +93,45 @@ public void process(K key, final Context context,
Iterable<T> values, Collector<
result = foldFunction.fold(result, val);
}
- windowFunction.process(key, windowFunction.new Context() {
+ ProcessWindowFunction<ACC, R, K, W>.Context ctx =
windowFunction.new Context() {
--- End diff --
This can benefit from a similar refactoring as the internal window
functions, i.e. creating an internal context class instead of the anonymous
inner classes.
This also holds for `FoldApplyProcessAllWindowFunction`,
`ReduceApplyProcessAllWindowFunction` and `ReduceApplyProcessWindowFunction`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
