Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3651#discussion_r108845132
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -222,19 +224,28 @@ private static void
validateOptionalPositiveDoubleProperty(Properties config, St
}
}
- private static void validateOptionalDateProperty(Properties config,
String key, String message) {
- if (config.containsKey(key)) {
- try {
-
initTimestampDateFormat.parse(config.getProperty(key));
- } catch (ParseException parseException) {
+ private static void validateOptionalDateProperty(Properties config,
String timestampKey, String formatKey, String message) {
+ if (config.containsKey(timestampKey)) {
+ if (config.containsKey(formatKey)) {
--- End diff --
This here too is a bit too complicated.
We can just determine what format will be used by `config.get(formatKey,
DEFAULT)`, and focus on validating the date. I don't think we need to make
things complicated by checking if the format key exists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
