Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3651#discussion_r108862488
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -224,27 +222,19 @@ private static void
validateOptionalPositiveDoubleProperty(Properties config, St
}
}
- private static void validateOptionalDateProperty(Properties config,
String timestampKey, String formatKey, String message) {
+ private static void validateOptionalDateProperty(Properties config,
String timestampKey, String format, String message) {
if (config.containsKey(timestampKey)) {
- if (config.containsKey(formatKey)) {
- try {
- SimpleDateFormat customDateFormat = new
SimpleDateFormat(config.getProperty(formatKey));
-
customDateFormat.parse(config.getProperty(timestampKey));
- } catch (ParseException |
IllegalArgumentException | NullPointerException exception) {
- throw new
IllegalArgumentException(message);
- }
- } else {
+ try {
+ SimpleDateFormat customDateFormat = new
SimpleDateFormat(format);
+
customDateFormat.parse(config.getProperty(timestampKey));
+ } catch (ParseException | IllegalArgumentException |
NullPointerException exception) {
try {
-
initTimestampDateFormat.parse(config.getProperty(timestampKey));
- } catch (ParseException exception) {
- try {
- double value =
Double.parseDouble(config.getProperty(timestampKey));
- if (value < 0) {
- throw new
NumberFormatException();
- }
- } catch (NumberFormatException
numberFormatException) {
- throw new
IllegalArgumentException(message);
+ double value =
Double.parseDouble(config.getProperty(timestampKey));
+ if (value < 0) {
+ throw new
NumberFormatException();
--- End diff --
Shouldn't we actually throw `new IllegalArgumentException(message)` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
