Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3651#discussion_r108885717
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -115,9 +115,15 @@ protected ShardConsumer(KinesisDataFetcher<T>
fetcherRef,
if
(lastSequenceNum.equals(SentinelSequenceNumber.SENTINEL_AT_TIMESTAMP_SEQUENCE_NUM.get()))
{
String timestamp =
consumerConfig.getProperty(ConsumerConfigConstants.STREAM_INITIAL_TIMESTAMP);
+
try {
- this.initTimestamp =
KinesisConfigUtil.initTimestampDateFormat.parse(timestamp);
- } catch (ParseException e) {
+ String format =
consumerConfig.getProperty(ConsumerConfigConstants.STREAM_TIMESTAMP_DATE_FORMAT,
+
ConsumerConfigConstants.DEFAULT_STREAM_TIMESTAMP_DATE_FORMAT);
+ SimpleDateFormat customDateFormat = new
SimpleDateFormat(format);
+ this.initTimestamp =
customDateFormat.parse(timestamp);
+ } catch (IllegalArgumentException |
NullPointerException exception) {
+ throw new
IllegalArgumentException(exception.getCause());
--- End diff --
I think we should just wrap the whole exception instance and not only the
exception object here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
