Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3661#discussion_r109821341
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
 ---
    @@ -2560,7 +2560,7 @@ public int compare(Object o1, Object o2) {
                                        if (comparison != 0) {
                                                return comparison;
                                        }
    -                                   return (int) (sr0.getValue().f1 - 
sr1.getValue().f1);
    +                                   return (int) (sr0.getValue().f2 - 
sr1.getValue().f2);
    --- End diff --
    
    @aljoscha this line compares second field again rather than the third field.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to