[
https://issues.apache.org/jira/browse/FLINK-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206169#comment-14206169
]
ASF GitHub Bot commented on FLINK-1040:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/194#discussion_r20138116
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/ProjectOperator.java
---
@@ -63,11 +73,21 @@ public ProjectOperator(DataSet<IN> input, int[] fields,
TupleTypeInfo<OUT> retur
return ppo;
}
-
+
+ @SuppressWarnings("hiding")
+ public <OUT extends Tuple> ProjectOperator<?, OUT> projection(int...
fieldIndexes) {
+ proj.acceptAdditionalIndexes(fieldIndexes);
+
+ return proj.types();
+ }
+
+
public static class Projection<T> {
private final DataSet<T> ds;
- private final int[] fieldIndexes;
+// private final int[] fieldIndexes;
--- End diff --
remove line
> Make type() call in projections optional (or remove it)
> -------------------------------------------------------
>
> Key: FLINK-1040
> URL: https://issues.apache.org/jira/browse/FLINK-1040
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Stephan Ewen
> Priority: Minor
> Labels: simple, starter
>
> I think the type() call should be optional. The compiler can also cast the
> data set directly and the result type is computed from the input types
> anyways.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
