[
https://issues.apache.org/jira/browse/FLINK-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206213#comment-14206213
]
ASF GitHub Bot commented on FLINK-1040:
---------------------------------------
Github user dukechain commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/194#discussion_r20140135
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/JoinOperator.java
---
@@ -1215,8 +1735,7 @@ public JoinProjection(DataSet<I1> ds1, DataSet<I2>
ds2, Keys<I1> keys1, Keys<I2>
* Projects a pair of joined elements to a {@link Tuple} with
the previously selected fields.
* Requires the classes of the fields of the resulting tuples.
*
- * @param type0 The class of field '0' of the result tuples.
- * @param type1 The class of field '1' of the result tuples.
+ * @param type0 The class of field '0' of the result tuples.
@param type1 The class of field '1' of the result tuples.
--- End diff --
It seems "mvn verify" does not permit a .java file exceeds 2500 lines.
Anyway, these types() would not be used again if we drop types() in project().
I would remove them totally.
> Make type() call in projections optional (or remove it)
> -------------------------------------------------------
>
> Key: FLINK-1040
> URL: https://issues.apache.org/jira/browse/FLINK-1040
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Stephan Ewen
> Priority: Minor
> Labels: simple, starter
>
> I think the type() call should be optional. The compiler can also cast the
> data set directly and the result type is computed from the input types
> anyways.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
