[
https://issues.apache.org/jira/browse/FLINK-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220723#comment-14220723
]
ASF GitHub Bot commented on FLINK-1040:
---------------------------------------
Github user dukechain commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/194#discussion_r20705922
--- Diff:
flink-compiler/src/test/java/org/apache/flink/compiler/custompartition/CustomPartitioningGlobalOptimizationTest.java
---
@@ -49,10 +52,11 @@ public void testJoinReduceCombination() {
DataSet<Tuple2<Long, Long>> input1 =
env.fromElements(new Tuple2<Long, Long>(0L, 0L));
DataSet<Tuple3<Long, Long, Long>> input2 =
env.fromElements(new Tuple3<Long, Long, Long>(0L, 0L, 0L));
- DataSet<Tuple3<Long, Long, Long>> joined =
input1.join(input2)
+ ProjectJoin<Tuple2<Long, Long>,Tuple3<Long, Long,
Long>,Tuple3<Long, Long, Long>> projectjoin = input1.join(input2)
.where(1).equalTo(0)
-
.projectFirst(0,1).projectSecond(2).types(Long.class, Long.class, Long.class)
- .withPartitioner(partitioner);
+ .projectFirst(0,1).projectSecond(2);
+
+ DataSet<Tuple3<Long, Long, Long>> joined =
projectjoin.withPartitioner(partitioner);
--- End diff --
Yes, we can open a JIRA issue after this branch merged.
> Make type() call in projections optional (or remove it)
> -------------------------------------------------------
>
> Key: FLINK-1040
> URL: https://issues.apache.org/jira/browse/FLINK-1040
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Stephan Ewen
> Priority: Minor
> Labels: simple, starter
>
> I think the type() call should be optional. The compiler can also cast the
> data set directly and the result type is computed from the input types
> anyways.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
