[
https://issues.apache.org/jira/browse/FLINK-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226044#comment-14226044
]
ASF GitHub Bot commented on FLINK-1040:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/194#discussion_r20928980
--- Diff:
flink-examples/flink-java-examples/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery10.java
---
@@ -146,9 +146,9 @@ public boolean filter(Tuple4<Integer, Double, Double,
String> l) {
DataSet<Tuple2<Integer, Double>> revenueByCustomer =
ordersFilteredByYear.joinWithHuge(lineitemsFilteredByFlag)
.where(0).equalTo(0)
-
.projectFirst(1).projectSecond(1)
-
.types(Integer.class, Double.class)
--- End diff --
This example still contains calls to `types(Class<?>...)`. Is this on
purpose? I think we should have the call out of all examples. Having them in
the tests is OK though. :)
> Make type() call in projections optional (or remove it)
> -------------------------------------------------------
>
> Key: FLINK-1040
> URL: https://issues.apache.org/jira/browse/FLINK-1040
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Stephan Ewen
> Priority: Minor
> Labels: simple, starter
>
> I think the type() call should be optional. The compiler can also cast the
> data set directly and the result type is computed from the input types
> anyways.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
