[ 
https://issues.apache.org/jira/browse/FLINK-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222969#comment-14222969
 ] 

ASF GitHub Bot commented on FLINK-1276:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/227#discussion_r20788430
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/CollectionEnvironment.java 
---
    @@ -24,13 +24,11 @@
     
     public class CollectionEnvironment extends ExecutionEnvironment {
     
    -   private boolean mutableObjectSafeMode = true;
    --- End diff --
    
    We actually want to make the execution mode configurable with a setter 
method, so this would actually be god to stay.
    
    We are thinking about how to do the configuration:
      - A set of setters
      - A configuration/parameter object
    
    I am leaning towards the second option, because we will have many more 
things to configure (closure cleaning, custom serializers, file system modes, 
mutable object modes)


> Misspelled class name SlotAvalablbilityListener.java
> ----------------------------------------------------
>
>                 Key: FLINK-1276
>                 URL: https://issues.apache.org/jira/browse/FLINK-1276
>             Project: Flink
>          Issue Type: Bug
>          Components: Local Runtime
>    Affects Versions: 0.8-incubating
>            Reporter: Suneel Marthi
>            Assignee: Suneel Marthi
>            Priority: Trivial
>             Fix For: 0.8-incubating
>
>
> 1. Misspelled Class name - 'SlotAvailablblityListener'.
> 2. All methods in MathUtils.java are declared as static final.
> 3. Many other minor fixes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to