[
https://issues.apache.org/jira/browse/FLINK-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222975#comment-14222975
]
ASF GitHub Bot commented on FLINK-1276:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/227#discussion_r20788734
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/CoLocationConstraint.java
---
@@ -49,10 +49,7 @@ public Instance getLocation() {
}
public void setSharedSlot(SharedSlot sharedSlot) {
- if (this.sharedSlot == sharedSlot) {
--- End diff --
Is this correct? Does the second condition subsume the first?
> Misspelled class name SlotAvalablbilityListener.java
> ----------------------------------------------------
>
> Key: FLINK-1276
> URL: https://issues.apache.org/jira/browse/FLINK-1276
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
> Affects Versions: 0.8-incubating
> Reporter: Suneel Marthi
> Assignee: Suneel Marthi
> Priority: Trivial
> Fix For: 0.8-incubating
>
>
> 1. Misspelled Class name - 'SlotAvailablblityListener'.
> 2. All methods in MathUtils.java are declared as static final.
> 3. Many other minor fixes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
