Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/203#discussion_r21740407
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -98,14 +99,18 @@ protected DataSet(ExecutionEnvironment context,
TypeInformation<T> type) {
throw new NullPointerException("context is null");
}
- if (type == null) {
- throw new NullPointerException("type is null");
- }
-
this.context = context;
this.type = type;
}
+ protected void setType(TypeInformation<T> type) {
--- End diff --
May be good to make this a little safer here, now that the type info is no
longer final.
We could call this `fillInTypeInfo()` and check whether the type info is
currently null, (or a MissingTypeInfo) and only then allow to change the field.
Otherwise throw an IllegalStateException.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
