[ 
https://issues.apache.org/jira/browse/FLINK-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249667#comment-14249667
 ] 

ASF GitHub Bot commented on FLINK-610:
--------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/271#issuecomment-67300275
  
    Very good idea. I think we could fix this still a bit and make it better:
    
      - Avro created a schema from the objects to serialize (somewhat a simple 
thing as our POJO analysis). That way, it does not need to write all 
classnames. Kryo writes all classnames by default, which is very painful, 
unless they are registered. I think that was one of the reasons why Avro was 
actually faster for us out of the box.
         - We should register the types at Kryo that we see as being 
(recursively contained in the type information)
         - We should also allow at the execution environment to manually 
register types or serializers.
    
      - Why is the `copy()` method not using Kryo's copy functionality? The 
current implementation seems painfully inefficient, and will still be used 
until @aljoscha 's change about reuse/non-reuse mode is in.
    
      - The tests that have a hardwired check for the KryoSerializer break 
design...
    
    
    It seems that the Java/Scala code is moving closer together still, with the 
common serializer being configured in the Java API for Scala classes. That 
means we might really collapse the projects at some point.


> Replace Avro serialization by Kryo 
> -----------------------------------
>
>                 Key: FLINK-610
>                 URL: https://issues.apache.org/jira/browse/FLINK-610
>             Project: Flink
>          Issue Type: Bug
>          Components: Java API
>            Reporter: GitHub Import
>            Assignee: Robert Metzger
>            Priority: Critical
>              Labels: github-import
>             Fix For: pre-apache
>
>
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/610
> Created by: [rmetzger|https://github.com/rmetzger]
> Labels: java api, 
> Milestone: Release 0.6 (unplanned)
> Created at: Tue Mar 18 17:29:28 CET 2014
> State: open



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to