[
https://issues.apache.org/jira/browse/FLINK-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249711#comment-14249711
]
ASF GitHub Bot commented on FLINK-610:
--------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/271#issuecomment-67307001
Thank you for the feedback.
* We are using the Twitter Chill library. It registers many commonly used
classes with Kryo (Collections, Date, BigInt, ...). So the issue with class
names being written does only apply to userdefined types.
You are indeed right that we should provide facilities to register custom
classes and that we should register all classes we see during type analysis.
I didn't implement these features because Timo is actually working on this
and I wanted to have at least basic Kryo support in the release. Timo will
integrate Kryo more tightly with the type analysis.
* The `copy()` method of Kryo is not implemented for many types (in
particular those by Chill). For example the java.sql.Date type
(https://github.com/twitter/chill/blob/develop/chill-java/src/main/java/com/twitter/chill/java/SqlDateSerializer.java)
doesn't have a copy() method.
Kryo provides a default copy() method which fails on mutable types.
(https://github.com/EsotericSoftware/kryo/blob/master/src/com/esotericsoftware/kryo/Serializer.java#L102).
I thought about contributing the missing copy() methods for chill.
We could also whitelist some classes for kryo's copy and fall back to the
slow variant.
* The hardwired check for the KryoSerializer is very ugly. Maybe I can come
up with a different solution. Till suggested to add a method
(`canCreateInstance`) to all serializers .. but thats a lot of code for one
test case.
> Replace Avro serialization by Kryo
> -----------------------------------
>
> Key: FLINK-610
> URL: https://issues.apache.org/jira/browse/FLINK-610
> Project: Flink
> Issue Type: Bug
> Components: Java API
> Reporter: GitHub Import
> Assignee: Robert Metzger
> Priority: Critical
> Labels: github-import
> Fix For: pre-apache
>
>
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/610
> Created by: [rmetzger|https://github.com/rmetzger]
> Labels: java api,
> Milestone: Release 0.6 (unplanned)
> Created at: Tue Mar 18 17:29:28 CET 2014
> State: open
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
