Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/290#discussion_r22646878
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/bufferprovider/GlobalBufferPool.java
---
@@ -63,8 +64,13 @@ public GlobalBufferPool(int numBuffers, int bufferSize) {
for (int i = 0; i < numBuffers; i++) {
try {
- byte[] buf = new byte[bufferSize];
- buffers.add(new MemorySegment(buf));
+ // TODO if (config) {
--- End diff --
The direct memory segments are never used. I think you forgot this TODO
here. ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
