swuferhong commented on code in PR #1531:
URL: https://github.com/apache/fluss/pull/1531#discussion_r2278422185
##########
fluss-common/src/main/java/com/alibaba/fluss/metrics/MetricNames.java:
##########
@@ -100,7 +100,6 @@ public class MetricNames {
// for replica
public static final String UNDER_REPLICATED = "underReplicated";
- public static final String IN_SYNC_REPLICAS = "inSyncReplicasCount";
public static final String UNDER_MIN_ISR = "underMinIsr";
public static final String AT_MIN_ISR = "atMinIsr";
Review Comment:
Move these metric names to the `TabletServer section` above, as they now
belong to the TabletServer level.
##########
website/docs/maintenance/observability/monitor-metrics.md:
##########
@@ -631,12 +631,7 @@ Some metrics might not be exposed when using other JVM
implementations (e.g. IBM
<td>Meter</td>
</tr>
<tr>
- <td rowspan="7">table_bucket</td>
- <td>inSyncReplicasCount</td>
- <td>The inSync replicas count of this table bucket.</td>
- <td>Gauge</td>
- </tr>
- <tr>
Review Comment:
ditto, Move the modified metrics to correct table plane.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
