wuchong commented on code in PR #1531:
URL: https://github.com/apache/fluss/pull/1531#discussion_r2339217212
##########
fluss-common/src/main/java/org/apache/fluss/metrics/MetricNames.java:
##########
@@ -94,35 +94,37 @@ public class MetricNames {
public static final String FAILED_PREFIX_LOOKUP_REQUESTS_RATE =
"failedPrefixLookupRequestsPerSecond";
- //
--------------------------------------------------------------------------------------------
- // metrics for table bucket
- //
--------------------------------------------------------------------------------------------
-
// for replica
public static final String UNDER_REPLICATED = "underReplicated";
- public static final String IN_SYNC_REPLICAS = "inSyncReplicasCount";
public static final String UNDER_MIN_ISR = "underMinIsr";
public static final String AT_MIN_ISR = "atMinIsr";
public static final String ISR_EXPANDS_RATE = "isrExpandsPerSecond";
public static final String ISR_SHRINKS_RATE = "isrShrinksPerSecond";
public static final String FAILED_ISR_UPDATES_RATE =
"failedIsrUpdatesPerSecond";
// for log tablet
- public static final String LOG_NUM_SEGMENTS = "numSegments";
- public static final String LOG_END_OFFSET = "endOffset";
- public static final String LOG_SIZE = "size";
public static final String LOG_FLUSH_RATE = "flushPerSecond";
Review Comment:
Considering this will be moved from bucket-level to server-level, it's
better to add "log" prefix to distinguish with the metric of kv. E.g.,
`logFlushPerSecond` and `logFlushLatencyMs`
##########
fluss-common/src/main/java/org/apache/fluss/metrics/MetricNames.java:
##########
@@ -94,35 +94,37 @@ public class MetricNames {
public static final String FAILED_PREFIX_LOOKUP_REQUESTS_RATE =
"failedPrefixLookupRequestsPerSecond";
- //
--------------------------------------------------------------------------------------------
- // metrics for table bucket
- //
--------------------------------------------------------------------------------------------
-
// for replica
public static final String UNDER_REPLICATED = "underReplicated";
- public static final String IN_SYNC_REPLICAS = "inSyncReplicasCount";
public static final String UNDER_MIN_ISR = "underMinIsr";
public static final String AT_MIN_ISR = "atMinIsr";
public static final String ISR_EXPANDS_RATE = "isrExpandsPerSecond";
public static final String ISR_SHRINKS_RATE = "isrShrinksPerSecond";
public static final String FAILED_ISR_UPDATES_RATE =
"failedIsrUpdatesPerSecond";
// for log tablet
- public static final String LOG_NUM_SEGMENTS = "numSegments";
- public static final String LOG_END_OFFSET = "endOffset";
- public static final String LOG_SIZE = "size";
public static final String LOG_FLUSH_RATE = "flushPerSecond";
public static final String LOG_FLUSH_LATENCY_MS = "flushLatencyMs";
// for kv tablet
- public static final String KV_LATEST_SNAPSHOT_SIZE = "latestSnapshotSize";
public static final String KV_PRE_WRITE_BUFFER_TRUNCATE_AS_DUPLICATED_RATE
=
Review Comment:
We should remove the `void registerMetrics(BucketMetricGroup
bucketMetricGroup)` of `KvTablet`, because we don't need to report bucket-level
pre-write-buffer metrics.
##########
fluss-common/src/main/java/org/apache/fluss/metrics/MetricNames.java:
##########
@@ -94,35 +94,37 @@ public class MetricNames {
public static final String FAILED_PREFIX_LOOKUP_REQUESTS_RATE =
"failedPrefixLookupRequestsPerSecond";
- //
--------------------------------------------------------------------------------------------
- // metrics for table bucket
- //
--------------------------------------------------------------------------------------------
-
// for replica
public static final String UNDER_REPLICATED = "underReplicated";
- public static final String IN_SYNC_REPLICAS = "inSyncReplicasCount";
public static final String UNDER_MIN_ISR = "underMinIsr";
public static final String AT_MIN_ISR = "atMinIsr";
public static final String ISR_EXPANDS_RATE = "isrExpandsPerSecond";
public static final String ISR_SHRINKS_RATE = "isrShrinksPerSecond";
public static final String FAILED_ISR_UPDATES_RATE =
"failedIsrUpdatesPerSecond";
// for log tablet
- public static final String LOG_NUM_SEGMENTS = "numSegments";
- public static final String LOG_END_OFFSET = "endOffset";
- public static final String LOG_SIZE = "size";
public static final String LOG_FLUSH_RATE = "flushPerSecond";
public static final String LOG_FLUSH_LATENCY_MS = "flushLatencyMs";
// for kv tablet
- public static final String KV_LATEST_SNAPSHOT_SIZE = "latestSnapshotSize";
public static final String KV_PRE_WRITE_BUFFER_TRUNCATE_AS_DUPLICATED_RATE
=
"preWriteBufferTruncateAsDuplicatedPerSecond";
public static final String KV_PRE_WRITE_BUFFER_TRUNCATE_AS_ERROR_RATE =
"preWriteBufferTruncateAsErrorPerSecond";
public static final String KV_PRE_WRITE_BUFFER_FLUSH_RATE =
"preWriteBufferFlushPerSecond";
public static final String KV_PRE_WRITE_BUFFER_FLUSH_LATENCY_MS =
"preWriteBufferFlushLatencyMs";
Review Comment:
It's better to name them `kvFlushPerSecond` and `kvFlushLatencyMs` to keep
align with the log metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]