Copilot commented on code in PR #2531: URL: https://github.com/apache/fluss/pull/2531#discussion_r2746134799
########## website/docs/maintenance/operations/upgrade-notes-0.9.md: ########## @@ -1,4 +1,4 @@ ---- + Review Comment: The frontmatter section should start at line 1 without a blank line before it. The YAML frontmatter in Markdown files must start with "---" at the very beginning of the file. This blank line may cause parsing issues with documentation generation tools. ```suggestion --- ``` ########## website/docs/maintenance/operations/upgrade-notes-0.9.md: ########## @@ -50,3 +50,27 @@ The following options are deprecated and will be removed in a future version: - **Simplified Configuration**: One option instead of multiple options for IO thread pool management - **Better Resource Management**: Unified thread pool allows better resource sharing across different IO operations - **Consistent Behavior**: All IO operations (remote log, KV snapshot, etc.) now use the same thread pool configuration + +## Paimon Integration + +### Manual Paimon Bundle Dependency Required + +Starting from Fluss 0.9, the `fluss-lake-paimon` JAR no longer bundles `paimon-bundle`. Previously, including `paimon-bundle` inside `fluss-lake-paimon` caused class conflicts during union reads when users had a different version of Paimon in their environment. + +🔧 **Action Required**: Manually add a compatible `paimon-bundle` JAR to your Flink `lib` directory. + +#### Migration Steps + +1. **Download the Paimon bundle**: + - Download the appropriate `paimon-flink-<flink-version>` bundle JAR from the [Apache Paimon Downloads](https://paimon.apache.org/docs/1.3/project/download/) page + - Choose a version compatible with your Flink version and your use case + +2. **Deploy the JAR**: + - Copy the downloaded `paimon-flink-*.jar` to `$FLINK_HOME/lib/` Review Comment: The instruction mentions copying "paimon-flink-*.jar" but based on the migration guidance in other parts of this document and elsewhere, it should be "paimon-bundle-*.jar" for consistency. The upgrade notes should use the same terminology as the rest of the documentation. ```suggestion - Copy the downloaded `paimon-bundle-*.jar` to `$FLINK_HOME/lib/` ``` ########## website/docs/maintenance/operations/upgrade-notes-0.9.md: ########## @@ -50,3 +50,27 @@ The following options are deprecated and will be removed in a future version: - **Simplified Configuration**: One option instead of multiple options for IO thread pool management - **Better Resource Management**: Unified thread pool allows better resource sharing across different IO operations - **Consistent Behavior**: All IO operations (remote log, KV snapshot, etc.) now use the same thread pool configuration + +## Paimon Integration + +### Manual Paimon Bundle Dependency Required + +Starting from Fluss 0.9, the `fluss-lake-paimon` JAR no longer bundles `paimon-bundle`. Previously, including `paimon-bundle` inside `fluss-lake-paimon` caused class conflicts during union reads when users had a different version of Paimon in their environment. + +🔧 **Action Required**: Manually add a compatible `paimon-bundle` JAR to your Flink `lib` directory. + +#### Migration Steps + +1. **Download the Paimon bundle**: + - Download the appropriate `paimon-flink-<flink-version>` bundle JAR from the [Apache Paimon Downloads](https://paimon.apache.org/docs/1.3/project/download/) page + - Choose a version compatible with your Flink version and your use case + +2. **Deploy the JAR**: + - Copy the downloaded `paimon-flink-*.jar` to `$FLINK_HOME/lib/` Review Comment: The documentation mentions downloading "paimon-flink-<flink-version> bundle JAR" but the correct artifact name is "paimon-flink-<version>" or "paimon-bundle". The text should be consistent with other documentation that refers to "paimon-bundle". Additionally, the download link should point to a specific artifact (e.g., paimon-bundle-1.3.1.jar) for clarity, consistent with line 67 in the lakehouse-storage.md file. ```suggestion - Download the appropriate `paimon-bundle-<version>.jar` (for example, `paimon-bundle-1.3.1.jar`) from the [Apache Paimon Downloads](https://paimon.apache.org/docs/1.3/project/download/) page - Choose a version compatible with your Flink version and your use case 2. **Deploy the JAR**: - Copy the downloaded `paimon-bundle-*.jar` to `$FLINK_HOME/lib/` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
