wuchong commented on code in PR #2531:
URL: https://github.com/apache/fluss/pull/2531#discussion_r2753279232
##########
website/src/plugins/remark-version-replace/index.js:
##########
@@ -53,7 +53,9 @@ const plugin = (options) => {
const replacements = {
"$FLUSS_VERSION$": version.fullVersion,
"$FLUSS_VERSION_SHORT$": version.shortVersion,
- "$FLUSS_DOCKER_VERSION$": version.dockerVersion
+ "$FLUSS_DOCKER_VERSION$": version.dockerVersion,
+ "$PAIMON_VERSION$": "1.3.1",
+ "$PAIMON_VERSION_SHORT$": "1.3"
Review Comment:
We shouldn’t hard-code the Paimon version in `index.js`, as this file is
shared across all versioned documentation sites.
For example, if we release Fluss 0.9 with Paimon 1.3.1, and later upgrade to
Paimon 1.4.1 in a subsequent Fluss version, the shared `index.js` would
incorrectly update the **0.9 documentation** to reference Paimon 1.4.1—even
though that combination was never tested and may be incompatible.
To ensure version accuracy and isolation, we should move such
version-specific variables into `fluss-versions.json`, where they can be
properly scoped per Fluss release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
