fresh-borzoni commented on code in PR #288:
URL: https://github.com/apache/fluss-rust/pull/288#discussion_r2780019753
##########
bindings/cpp/include/fluss.hpp:
##########
@@ -833,7 +898,13 @@ class Table {
bool Available() const;
+ GenericRow NewRow() const;
+
Result NewAppendWriter(AppendWriter& out);
+ Result NewUpsertWriter(UpsertWriter& out);
+ Result NewUpsertWriter(UpsertWriter& out, const std::vector<std::string>&
column_names);
+ Result NewUpsertWriter(UpsertWriter& out, const std::vector<size_t>&
column_indices);
Review Comment:
A good point, I checked and Java already has MergeMode, so it makes even
more sense.
Python is good with kwargs, so it's only CPP
I created an issue: https://github.com/apache/fluss-rust/issues/293. I'll
address it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
