fresh-borzoni commented on code in PR #288:
URL: https://github.com/apache/fluss-rust/pull/288#discussion_r2780059683
##########
bindings/cpp/src/types.rs:
##########
@@ -430,99 +413,106 @@ fn core_row_to_ffi_fields(
for (i, field) in schema.fields().iter().enumerate() {
if row.is_null_at(i) {
- fields.push(new_datum(DATUM_TYPE_NULL));
+ fields.push(ffi::FfiDatum::default());
continue;
}
let datum = match field.data_type() {
- ArrowDataType::Boolean => {
- let mut datum = new_datum(DATUM_TYPE_BOOL);
- datum.bool_val = row.get_boolean(i);
- datum
- }
- ArrowDataType::Int8 => {
- let mut datum = new_datum(DATUM_TYPE_INT32);
- datum.i32_val = row.get_byte(i) as i32;
- datum
- }
- ArrowDataType::Int16 => {
- let mut datum = new_datum(DATUM_TYPE_INT32);
- datum.i32_val = row.get_short(i) as i32;
- datum
- }
- ArrowDataType::Int32 => {
- let mut datum = new_datum(DATUM_TYPE_INT32);
- datum.i32_val = row.get_int(i);
- datum
- }
- ArrowDataType::Int64 => {
- let mut datum = new_datum(DATUM_TYPE_INT64);
- datum.i64_val = row.get_long(i);
- datum
- }
- ArrowDataType::Float32 => {
- let mut datum = new_datum(DATUM_TYPE_FLOAT32);
- datum.f32_val = row.get_float(i);
- datum
- }
- ArrowDataType::Float64 => {
- let mut datum = new_datum(DATUM_TYPE_FLOAT64);
- datum.f64_val = row.get_double(i);
- datum
- }
- ArrowDataType::Utf8 => {
- let mut datum = new_datum(DATUM_TYPE_STRING);
- // todo: avoid copy string
- datum.string_val = row.get_string(i).to_string();
- datum
- }
+ ArrowDataType::Boolean => ffi::FfiDatum {
+ datum_type: DATUM_TYPE_BOOL,
+ bool_val: row.get_boolean(i),
+ ..Default::default()
+ },
+ ArrowDataType::Int8 => ffi::FfiDatum {
+ datum_type: DATUM_TYPE_INT32,
+ i32_val: row.get_byte(i) as i32,
+ ..Default::default()
+ },
+ ArrowDataType::Int16 => ffi::FfiDatum {
+ datum_type: DATUM_TYPE_INT32,
+ i32_val: row.get_short(i) as i32,
+ ..Default::default()
+ },
Review Comment:
It's the read path (Rust to C++), where i8/i16 are widened to i32. This is
lossless and safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
