fresh-borzoni commented on code in PR #294:
URL: https://github.com/apache/fluss-rust/pull/294#discussion_r2785314841
##########
bindings/cpp/src/table.cpp:
##########
@@ -129,25 +129,54 @@ TableScan Table::NewScan() { return TableScan(table_); }
// TableScan implementation
TableScan::TableScan(ffi::Table* table) noexcept : table_(table) {}
-TableScan& TableScan::Project(std::vector<size_t> column_indices) {
+TableScan& TableScan::ProjectByIndex(std::vector<size_t> column_indices) {
Review Comment:
Hmm, okay, though I think it's better to have symmetrical methods, because
users usually think in names, so now it feels odd as if default is indices.
Should we change this in all clients to symmetrical methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
