fresh-borzoni commented on code in PR #294:
URL: https://github.com/apache/fluss-rust/pull/294#discussion_r2786995482
##########
bindings/cpp/src/table.cpp:
##########
@@ -129,25 +129,54 @@ TableScan Table::NewScan() { return TableScan(table_); }
// TableScan implementation
TableScan::TableScan(ffi::Table* table) noexcept : table_(table) {}
-TableScan& TableScan::Project(std::vector<size_t> column_indices) {
+TableScan& TableScan::ProjectByIndex(std::vector<size_t> column_indices) {
Review Comment:
in C++17 overload Project({"id", "balance"}) is ambiguous because const
char* -> size_t is a valid conversion, so I'll follow rust/python approach.
e.g.
The compiler can't pick between `vector<size_t>` and `vector<string>`
because `const char*` is convertible to both paths. You'd have to write the
verbose form:
`Project(std::vector<std::string>{"id", "balance"});`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
