[
https://issues.apache.org/jira/browse/GEODE-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054937#comment-16054937
]
ASF GitHub Bot commented on GEODE-3073:
---------------------------------------
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/591#discussion_r122849064
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java
---
@@ -941,17 +940,16 @@ private SelectResults
prepareEmptyResultSet(ExecutionContext context, boolean ig
SelectResults results;
if (this.distinct || !this.count) {
--- End diff --
This could stand to be flattened as well, although it will be more
difficult that the above. I could go either way on this chunk.
> Refactor/rename OrderByComparatorUnmapped
> -----------------------------------------
>
> Key: GEODE-3073
> URL: https://issues.apache.org/jira/browse/GEODE-3073
> Project: Geode
> Issue Type: Improvement
> Components: querying
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> It would make more sense to rename {{OrderByComparatorUnmapped.java}} to
> {{OrderByComparatorMapped.java}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
